Avoid interference between different construct association in name resolutions #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue 598 and related issues. Transform resolve-names.cc ConstructVisitor association_ member into a stack so that different association construct (select-type, select-rank, change-team, associate) imbrication/succession do not interfere with each other leading to wrong erronous symbol resolution.
jeanPerier
requested review from
sscalpone,
ichoyjx,
tskeith,
schweitzpgi,
vjayathirtha-nv,
klausler,
vdonaldson and
psteinfeld
klausler
approved these changes
Jul 23, 2019
lib/semantics/resolve-names.cc
Outdated
| @@ -4407,6 +4440,20 @@ ConstructVisitor::Selector ConstructVisitor::ResolveSelector( | |||
| x.u); | |||
| } | |||
|
|
|||
| ConstructVisitor::Association &ConstructVisitor::GetCurrentAssociation() { | |||
| CHECK(associationStack_.size()); | |||
There was a problem hiding this comment.
!associationStack_.empty() makes the condition clearer. Also below.
swift-ci
pushed a commit
to apple/llvm-project
that referenced
this pull request
Apr 9, 2020
…oltions Fix issue 598 and related issues. Transform resolve-names.cc ConstructVisitor association_ member into a stack so that different association construct (select-type, select-rank, change-team, associate) imbrication/succession do not interfere with each other leading to wrong erronous symbol resolution. Original-commit: flang-compiler/f18@5781f29 Reviewed-on: flang-compiler/f18#600 Tree-same-pre-rewrite: false
swift-ci
pushed a commit
to apple/llvm-project
that referenced
this pull request
Apr 9, 2020
Original-commit: flang-compiler/f18@a346462 Reviewed-on: flang-compiler/f18#600
swift-ci
pushed a commit
to apple/llvm-project
that referenced
this pull request
Apr 9, 2020
…/jpr-fix-598 Avoid interference between different construct association in name resolutions Original-commit: flang-compiler/f18@28c32a7 Reviewed-on: flang-compiler/f18#600
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
…oltions Fix issue 598 and related issues. Transform resolve-names.cc ConstructVisitor association_ member into a stack so that different association construct (select-type, select-rank, change-team, associate) imbrication/succession do not interfere with each other leading to wrong erronous symbol resolution. Original-commit: flang-compiler/f18@5781f29 Reviewed-on: flang-compiler/f18#600 Tree-same-pre-rewrite: false
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Original-commit: flang-compiler/f18@a346462 Reviewed-on: flang-compiler/f18#600
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #598 and similar issues.
Transform
resolve-names.ccConstructVisitorassociation_member into a stack so that different association construct (select-type, select-rank, change-team, associate) imbrication/succession do not interfere with each other leading to erroneous symbol resolution.