Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with use-associated base of component reference #617

Merged
merged 1 commit into from Aug 2, 2019

Conversation

tskeith
Copy link
Collaborator

@tskeith tskeith commented Aug 2, 2019

When the base of a component reference (a in a%b) was use
associated, we were failing to follow it to the real symbol.

Fixes #616.

When the base of a component reference (`a` in `a%b`) was use
associated, we were failing to follow it to the real symbol.

Fixes #616.
Copy link
Collaborator

@psteinfeld psteinfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Should we add a test?

@tskeith
Copy link
Collaborator Author

tskeith commented Aug 2, 2019

Should we add a test?

I thought it was too minor to bother with a test.

@tskeith tskeith merged commit ded6d83 into master Aug 2, 2019
@tskeith tskeith deleted the tsk-issue616 branch August 2, 2019 17:20
swift-ci pushed a commit to apple/llvm-project that referenced this pull request Apr 9, 2020
When the base of a component reference (`a` in `a%b`) was use
associated, we were failing to follow it to the real symbol.

Fixes flang-compiler/f18#616.

Original-commit: flang-compiler/f18@95bfac6
Reviewed-on: flang-compiler/f18#617
swift-ci pushed a commit to apple/llvm-project that referenced this pull request Apr 9, 2020
…/tsk-issue616

Fix bug with use-associated base of component reference

Original-commit: flang-compiler/f18@ded6d83
Reviewed-on: flang-compiler/f18#617
mem-frob pushed a commit to draperlaboratory/hope-llvm-project that referenced this pull request Oct 7, 2022
When the base of a component reference (`a` in `a%b`) was use
associated, we were failing to follow it to the real symbol.

Fixes flang-compiler/f18#616.

Original-commit: flang-compiler/f18@95bfac6
Reviewed-on: flang-compiler/f18#617
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants