Allow module, submodule, and program names to be used as local identi… #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fiers. Check for USE of m in m.
tskeith
reviewed
Sep 11, 2019
| if (!scope) { | ||
| return nullptr; | ||
| } | ||
| if (scope->kind() != Scope::Kind::Module) { | ||
| Say(name, "'%s' is not a module"_err_en_US); | ||
| return nullptr; | ||
| } | ||
| if (DoesScopeContain(scope, currScope())) { | ||
| Say(name, "Module '%s' cannot USE itself."_err_en_US); |
There was a problem hiding this comment.
Should return nullptr here too?
There was a problem hiding this comment.
I worried that doing so would elicit needless error messages in the following code.
vdonaldson
reviewed
Sep 11, 2019
vdonaldson
reviewed
Sep 11, 2019
vdonaldson
approved these changes
Sep 11, 2019
|
Tim, any remaining concern? |
Nope, just forgot to hit Approve. |
tskeith
approved these changes
Sep 11, 2019
swift-ci
pushed a commit
to apple/llvm-project
that referenced
this pull request
Apr 9, 2020
…l identifiers. Check for USE of m in m. Original-commit: flang-compiler/f18@9abfd9e Reviewed-on: flang-compiler/f18#737 Tree-same-pre-rewrite: false
swift-ci
pushed a commit
to apple/llvm-project
that referenced
this pull request
Apr 9, 2020
Original-commit: flang-compiler/f18@9f918c2 Reviewed-on: flang-compiler/f18#737
swift-ci
pushed a commit
to apple/llvm-project
that referenced
this pull request
Apr 9, 2020
…/pmk-m-in-m Allow module, submodule, and program names to be used as local identi… Original-commit: flang-compiler/f18@ffc90d0 Reviewed-on: flang-compiler/f18#737
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
…l identifiers. Check for USE of m in m. Original-commit: flang-compiler/f18@9abfd9e Reviewed-on: flang-compiler/f18#737 Tree-same-pre-rewrite: false
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Original-commit: flang-compiler/f18@9f918c2 Reviewed-on: flang-compiler/f18#737
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…fiers. Check for USE of m in m.