Fix bug merging generics on USE #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we use-associate the same generic name from two different modules they are merged together. If the same specific procedure occurs in both generics it should only occur once in the merged one. Similarly, it's not an error if they both have a derived type or specific procedure named the same as the generic, as long as they are the same symbol. Fixes #733.
tskeith
requested review from
ichoyjx,
jeanPerier,
schweitzpgi,
vjayathirtha-nv,
klausler and
psteinfeld
jeanPerier
reviewed
Sep 13, 2019
klausler
approved these changes
Sep 13, 2019
lib/semantics/symbol.cc
Outdated
| auto &procs{from.specificProcs_}; | ||
| specificProcs_.insert(specificProcs_.end(), procs.begin(), procs.end()); | ||
| for (const Symbol *symbol : from.specificProcs_) { | ||
| auto it{std::find(specificProcs_.begin(), specificProcs_.end(), symbol)}; |
There was a problem hiding this comment.
I'd bash these two lines together and avoid the needless temporary. Calling find and comparing its result to end() is idiomatic.
If a generic name is use-associated from two different modules and they both have a specific procedure or both have a derived type with the same name, report it as an error.
jeanPerier
approved these changes
Sep 16, 2019
swift-ci
pushed a commit
to apple/llvm-project
that referenced
this pull request
Apr 9, 2020
When we use-associate the same generic name from two different modules they are merged together. If the same specific procedure occurs in both generics it should only occur once in the merged one. Similarly, it's not an error if they both have a derived type or specific procedure named the same as the generic, as long as they are the same symbol. Fixes flang-compiler/f18#733. Original-commit: flang-compiler/f18@d37db07 Reviewed-on: flang-compiler/f18#741 Tree-same-pre-rewrite: false
swift-ci
pushed a commit
to apple/llvm-project
that referenced
this pull request
Apr 9, 2020
If a generic name is use-associated from two different modules and they both have a specific procedure or both have a derived type with the same name, report it as an error. Original-commit: flang-compiler/f18@42369af Reviewed-on: flang-compiler/f18#741 Tree-same-pre-rewrite: false
swift-ci
pushed a commit
to apple/llvm-project
that referenced
this pull request
Apr 9, 2020
Original-commit: flang-compiler/f18@134190f Reviewed-on: flang-compiler/f18#741
swift-ci
pushed a commit
to apple/llvm-project
that referenced
this pull request
Apr 9, 2020
…/tsk-issue733 Fix bug merging generics on USE Original-commit: flang-compiler/f18@5cedc81 Reviewed-on: flang-compiler/f18#741
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
When we use-associate the same generic name from two different modules they are merged together. If the same specific procedure occurs in both generics it should only occur once in the merged one. Similarly, it's not an error if they both have a derived type or specific procedure named the same as the generic, as long as they are the same symbol. Fixes flang-compiler/f18#733. Original-commit: flang-compiler/f18@d37db07 Reviewed-on: flang-compiler/f18#741 Tree-same-pre-rewrite: false
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
If a generic name is use-associated from two different modules and they both have a specific procedure or both have a derived type with the same name, report it as an error. Original-commit: flang-compiler/f18@42369af Reviewed-on: flang-compiler/f18#741 Tree-same-pre-rewrite: false
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Original-commit: flang-compiler/f18@134190f Reviewed-on: flang-compiler/f18#741
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we use-associate the same generic name from two different modules
they are merged together. If the same specific procedure occurs in both
generics it should only occur once in the merged one.
Similarly, it's not an error if they both have a derived type or
specific procedure named the same as the generic, as long as they are
the same symbol.
Fixes #733.