More procedure reference semantics checking (mostly arguments) #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tskeith
reviewed
Oct 4, 2019
tskeith
reviewed
Oct 4, 2019
tskeith
reviewed
Oct 4, 2019
tskeith
reviewed
Oct 4, 2019
tskeith
reviewed
Oct 4, 2019
tskeith
reviewed
Oct 4, 2019
tskeith
reviewed
Oct 5, 2019
tskeith
reviewed
Oct 5, 2019
tskeith
reviewed
Oct 5, 2019
tskeith
reviewed
Oct 5, 2019
tskeith
reviewed
Oct 5, 2019
tskeith
reviewed
Oct 5, 2019
tskeith
reviewed
Oct 5, 2019
tskeith
approved these changes
Oct 7, 2019
Extend documentation on preprocessing IsSimplyContiguous basic skeleton Apply suggested improvements to mod-file.cc Checks for new call13.f90 (15.4.2.2 explicit interfaces) Implement checking for procedures that can be called via an implicit interface Argument checking, test fixing Better argument checking Better derived type compatibility checking Treat externals as if implicitly interfaced Extend IEEE_EXCEPTIONS module so tests still pass with argument checking SAME_TYPE_AS and EXTENDS_TYPE_OF intrinsic inquiry functions Define interfaces for most intrinsic subroutines Better PASS arguments More with PASS() argument Prep for review address comments fix comment Remove formatted expression from specification expression error message per review more review comments
jeanPerier
reviewed
Oct 7, 2019
swift-ci
pushed a commit
to apple/llvm-project
that referenced
this pull request
Apr 9, 2020
Extend documentation on preprocessing IsSimplyContiguous basic skeleton Apply suggested improvements to mod-file.cc Checks for new call13.f90 (15.4.2.2 explicit interfaces) Implement checking for procedures that can be called via an implicit interface Argument checking, test fixing Better argument checking Better derived type compatibility checking Treat externals as if implicitly interfaced Extend IEEE_EXCEPTIONS module so tests still pass with argument checking SAME_TYPE_AS and EXTENDS_TYPE_OF intrinsic inquiry functions Define interfaces for most intrinsic subroutines Better PASS arguments More with PASS() argument Prep for review address comments fix comment Remove formatted expression from specification expression error message per review more review comments Original-commit: flang-compiler/f18@3cca775 Reviewed-on: flang-compiler/f18#776
swift-ci
pushed a commit
to apple/llvm-project
that referenced
this pull request
Apr 9, 2020
…/pmk-call More procedure reference semantics checking (mostly arguments) Original-commit: flang-compiler/f18@c582562 Reviewed-on: flang-compiler/f18#776
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Extend documentation on preprocessing IsSimplyContiguous basic skeleton Apply suggested improvements to mod-file.cc Checks for new call13.f90 (15.4.2.2 explicit interfaces) Implement checking for procedures that can be called via an implicit interface Argument checking, test fixing Better argument checking Better derived type compatibility checking Treat externals as if implicitly interfaced Extend IEEE_EXCEPTIONS module so tests still pass with argument checking SAME_TYPE_AS and EXTENDS_TYPE_OF intrinsic inquiry functions Define interfaces for most intrinsic subroutines Better PASS arguments More with PASS() argument Prep for review address comments fix comment Remove formatted expression from specification expression error message per review more review comments Original-commit: flang-compiler/f18@3cca775 Reviewed-on: flang-compiler/f18#776
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement checks of effective argument number, types, and ranks against the requirements of explicit and implicit interfaces. Handles calls to external subprograms for which interfaces are known but not explicit gracefully with warnings. Implements "same derived type" test for type compatibility (with some remaining TODO iterms). Implements insertion of
PASSarguments into argument lists, and the rearrangement of argument lists with keywords. Implements a predicate for simple contiguity -- this will be used more in later work.More argument checks are coming, but this branch was accumulating too many changes and is stable enough for review now.
Tested against f90_correct suite (and found some errors).