Further semantics checks for procedure references #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
checkpoint checkpoint
… intrinsics; further shape analysis of intrinsic results
jeanPerier
approved these changes
Oct 17, 2019
psteinfeld
reviewed
Oct 18, 2019
tskeith
reviewed
Oct 21, 2019
| messages.Say("Target type '%s' is not compatible with '%s'"_err_en_US, | ||
| that.type_.AsFortran(lenstr.str()), type_.AsFortran()); | ||
| messages.Say( | ||
| "%1$s type '%2$s' is not compatible with %3$s type '%4$s'"_err_en_US, |
There was a problem hiding this comment.
What does $s mean in the error format string?
There was a problem hiding this comment.
It selects the actual argument to be formatted. In this case, where 1$ through 4$ are used, the effect is the same as if they had not been present. I inserted them here in response to a comment about easing internationalization.
tskeith
reviewed
Oct 21, 2019
| @@ -84,6 +84,10 @@ bool CanBeTypeBoundProc(const Symbol *); | |||
| const Symbol *FindUltimateComponent( | |||
| const DerivedTypeSpec &type, std::function<bool(const Symbol &)> predicate); | |||
|
|
|||
| // Returns an immediate component of type that matches predicate, or nullptr. | |||
| const Symbol *FindImmediateComponent( | |||
| const DerivedTypeSpec &, const std::function<bool(const Symbol &)> &); | |||
There was a problem hiding this comment.
It might be helpful to define "immediate component" in the comment below that defined "ultimate component", etc.
tskeith
reviewed
Oct 21, 2019
| @@ -0,0 +1,475 @@ | |||
| // Copyright (c) 2019, NVIDIA CORPORATION. All rights reserved. | |||
There was a problem hiding this comment.
git seems to be treating this as a new file rather than a move, so I can't tell if there are changes to review here.
There was a problem hiding this comment.
There are, it's not just a move. I do not know why github failed to track the move on this file when it seemed to be able to do so on the other file that I moved (check-call.h). I will mail you a diff.
tskeith
approved these changes
Oct 21, 2019
swift-ci
pushed a commit
to apple/llvm-project
that referenced
this pull request
Apr 9, 2020
checkpoint checkpoint Original-commit: flang-compiler/f18@99d12a7 Reviewed-on: flang-compiler/f18#782 Tree-same-pre-rewrite: false
swift-ci
pushed a commit
to apple/llvm-project
that referenced
this pull request
Apr 9, 2020
Original-commit: flang-compiler/f18@7996c85 Reviewed-on: flang-compiler/f18#782 Tree-same-pre-rewrite: false
swift-ci
pushed a commit
to apple/llvm-project
that referenced
this pull request
Apr 9, 2020
Original-commit: flang-compiler/f18@4b71f00 Reviewed-on: flang-compiler/f18#782 Tree-same-pre-rewrite: false
swift-ci
pushed a commit
to apple/llvm-project
that referenced
this pull request
Apr 9, 2020
Original-commit: flang-compiler/f18@8c076bd Reviewed-on: flang-compiler/f18#782 Tree-same-pre-rewrite: false
swift-ci
pushed a commit
to apple/llvm-project
that referenced
this pull request
Apr 9, 2020
Original-commit: flang-compiler/f18@2691da3 Reviewed-on: flang-compiler/f18#782 Tree-same-pre-rewrite: false
swift-ci
pushed a commit
to apple/llvm-project
that referenced
this pull request
Apr 9, 2020
Original-commit: flang-compiler/f18@9cc70dc Reviewed-on: flang-compiler/f18#782 Tree-same-pre-rewrite: false
swift-ci
pushed a commit
to apple/llvm-project
that referenced
this pull request
Apr 9, 2020
Original-commit: flang-compiler/f18@eb43df8 Reviewed-on: flang-compiler/f18#782 Tree-same-pre-rewrite: false
swift-ci
pushed a commit
to apple/llvm-project
that referenced
this pull request
Apr 9, 2020
…HARACTER intrinsics; further shape analysis of intrinsic results Original-commit: flang-compiler/f18@561f596 Reviewed-on: flang-compiler/f18#782 Tree-same-pre-rewrite: false
swift-ci
pushed a commit
to apple/llvm-project
that referenced
this pull request
Apr 9, 2020
Original-commit: flang-compiler/f18@b9c890c Reviewed-on: flang-compiler/f18#782 Tree-same-pre-rewrite: false
swift-ci
pushed a commit
to apple/llvm-project
that referenced
this pull request
Apr 9, 2020
Original-commit: flang-compiler/f18@43720b5 Reviewed-on: flang-compiler/f18#782 Tree-same-pre-rewrite: false
swift-ci
pushed a commit
to apple/llvm-project
that referenced
this pull request
Apr 9, 2020
Original-commit: flang-compiler/f18@acd307c Reviewed-on: flang-compiler/f18#782 Tree-same-pre-rewrite: false
swift-ci
pushed a commit
to apple/llvm-project
that referenced
this pull request
Apr 9, 2020
Original-commit: flang-compiler/f18@e78db89 Reviewed-on: flang-compiler/f18#782
swift-ci
pushed a commit
to apple/llvm-project
that referenced
this pull request
Apr 9, 2020
…/pmk-calls Further semantics checks for procedure references Original-commit: flang-compiler/f18@fbdd919 Reviewed-on: flang-compiler/f18#782
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
checkpoint checkpoint Original-commit: flang-compiler/f18@99d12a7 Reviewed-on: flang-compiler/f18#782 Tree-same-pre-rewrite: false
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Original-commit: flang-compiler/f18@7996c85 Reviewed-on: flang-compiler/f18#782 Tree-same-pre-rewrite: false
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Original-commit: flang-compiler/f18@4b71f00 Reviewed-on: flang-compiler/f18#782 Tree-same-pre-rewrite: false
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Original-commit: flang-compiler/f18@8c076bd Reviewed-on: flang-compiler/f18#782 Tree-same-pre-rewrite: false
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Original-commit: flang-compiler/f18@2691da3 Reviewed-on: flang-compiler/f18#782 Tree-same-pre-rewrite: false
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Original-commit: flang-compiler/f18@9cc70dc Reviewed-on: flang-compiler/f18#782 Tree-same-pre-rewrite: false
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Original-commit: flang-compiler/f18@eb43df8 Reviewed-on: flang-compiler/f18#782 Tree-same-pre-rewrite: false
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
…HARACTER intrinsics; further shape analysis of intrinsic results Original-commit: flang-compiler/f18@561f596 Reviewed-on: flang-compiler/f18#782 Tree-same-pre-rewrite: false
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Original-commit: flang-compiler/f18@b9c890c Reviewed-on: flang-compiler/f18#782 Tree-same-pre-rewrite: false
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Original-commit: flang-compiler/f18@43720b5 Reviewed-on: flang-compiler/f18#782 Tree-same-pre-rewrite: false
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Original-commit: flang-compiler/f18@acd307c Reviewed-on: flang-compiler/f18#782 Tree-same-pre-rewrite: false
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Original-commit: flang-compiler/f18@e78db89 Reviewed-on: flang-compiler/f18#782
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These checks enable
call03.f90to pass. Other changes in this PR deal with fall-out from enabling these checks on some of our correctness tests (some bugs were exposed, now fixed). The checking code itself has migrated over tolib/semantics, which seems to be a more natural home. Intrinsic functions that returnCHARACTERlengths or indices have been reverted to returning (by default)INTEGERresults of the default kind, rather than subscript-sized integers.