Relax the implementation of constraint C1302. #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a format item list can be unambiguously partitioned into individual items even though one or more otherwise required comma separators are omitted, generate a warning rather than an error.
When a format item list can be unambiguously partitioned into individual items even though one or more otherwise required comma separators are omitted, generate a warning rather than an error. Fixes #703
vdonaldson
requested review from
ichoyjx,
jeanPerier,
klausler,
psteinfeld,
schweitzpgi,
sscalpone,
tskeith and
vjayathirtha-nv
klausler
reviewed
Nov 1, 2019
lib/common/format.h
Outdated
| @@ -102,6 +102,30 @@ template<typename CHAR = char> class FormatValidator { | |||
| String, // char-literal-constant or Hollerith constant | |||
| }; | |||
|
|
|||
| bool mayHaveLeadingInt(TokenKind desc) { | |||
There was a problem hiding this comment.
This is basically a set membership test; consider using EnumSet.
There was a problem hiding this comment.
Yes, it is. Doesn't EnumSet bring C++ library requirements with it?
There was a problem hiding this comment.
Whether a dependence on the binary C++ runtime support library is created probably depends on what parts of EnumSet one uses. I think you have a chance to just depend on things that are implemented in the standard headers in this case.
klausler
reviewed
Nov 1, 2019
lib/common/format.h
Outdated
| @@ -102,6 +102,30 @@ template<typename CHAR = char> class FormatValidator { | |||
| String, // char-literal-constant or Hollerith constant | |||
| }; | |||
|
|
|||
| bool mayHaveLeadingInt(TokenKind desc) { | |||
There was a problem hiding this comment.
This member function should be marked static or (better, if possible) static constexpr.
klausler
approved these changes
Nov 1, 2019
schweitzpgi
approved these changes
Nov 1, 2019
psteinfeld
approved these changes
Nov 1, 2019
Conflicts: lib/common/format.h
jeanPerier
approved these changes
Nov 5, 2019
tskeith
approved these changes
Nov 5, 2019
peterwaller-arm
pushed a commit
to peterwaller-arm/f18
that referenced
this pull request
Dec 5, 2019
* Relax the implementation of constraint C1302. When a list of format items can be unambiguously partitioned into individual items even though one or more otherwise required comma separators are omitted, generate a warning rather than an error. Fixes flang-compiler#703
swift-ci
pushed a commit
to apple/llvm-project
that referenced
this pull request
Apr 9, 2020
…/f18#805) * Relax the implementation of constraint C1302. When a list of format items can be unambiguously partitioned into individual items even though one or more otherwise required comma separators are omitted, generate a warning rather than an error. Fixes flang-compiler/f18#703 Original-commit: flang-compiler/f18@79c0731 Reviewed-on: flang-compiler/f18#805
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
…/f18#805) * Relax the implementation of constraint C1302. When a list of format items can be unambiguously partitioned into individual items even though one or more otherwise required comma separators are omitted, generate a warning rather than an error. Fixes flang-compiler/f18#703 Original-commit: flang-compiler/f18@79c0731 Reviewed-on: flang-compiler/f18#805
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a format item list can be unambiguously partitioned into individual
items even though one or more otherwise required comma separators are omitted,
generate a warning rather than an error.