[DebugInfo] Support for DWARF 4/5 and fix of issues related to -gdwarf-X options #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 12, 2020
|
Hi @gklimowicz |
Summary:
FLANG driver doesnt pass -gdwarf-4/5 to flang1 in form of xbits,
while it passes for -gdwarf-2/3
-gdwarf-2 => -x 120 0x200
-gdwarf-3 => -x 120 0x4000
Due to this -gdwarf-5 is never honored and default option -gdwarf-4
is taken.
# flang -gdwarf-5 test.f90
# llvm-dwarfdump a.out | grep version
0x00000000: Compile Unit: length = 0x0000008e version = 0x0004
Now 0x1000000/0x2000000 will be passed for -gdwarf-4/5
-gdwarf-4 => -x 120 0x1000000
-gdwarf-5 => -x 120 0x2000000
Testing:
- GNU gdb fortran testsuite
- check-llvm
- check-debuginfo
…entioned Summary: When multiple -g/-gdwarfN options are passed together at compile time, flang chooses the least one. Clang/gfortran etc choose the last one. -gdwarf-5 -gdwarf-3 => flang chooses 5 while clang/gfortran choose 3 -gdwarf-5 -g => flang choses the default while clang/gfortran choose 5 Testing: - check-llvm - check-debuginfo
Currently flang dumps dwarf version 2 for -g and 4 for absence of -g ------------------------- $ flang my.f90 $ llvm-dwarfdump a.out | grep version 0x00000000: Compile Unit: length = 0x0000003d version = 0x0004 abbr_offset = 0x0000 addr_size = 0x08 (next unit at 0x00000041) $ flang -g my.f90 $ llvm-dwarfdump a.out | grep version 0x00000000: Compile Unit: length = 0x00000047 version = 0x0002 abbr_offset = 0x0000 addr_size = 0x08 (next unit at 0x0000004b) ------------------------- It should be 4 for -g as it is the case with clang.
alokkrsharma
force-pushed
the
gdwarf_r90
branch
from
e545d46
to
16bd814
Compare
gklimowicz
approved these changes
Sep 12, 2020
There was a problem hiding this comment.
This looks good to me. I ran the tests on OpenPOWER and got the results I expected to see. Thank you @alokkrsharma
kiranchandramohan
approved these changes
Sep 13, 2020
| options::OPT_gdwarf_5); | ||
|
|
||
| if (GArg || GDwarfArg) { | ||
|
|
There was a problem hiding this comment.
Nit: Empty line? Does it match the style in the rest of this file?
| CommonCmdArgs.push_back("120"); | ||
| CommonCmdArgs.push_back("0x4000"); | ||
| if (!GDwarfArg) // -g without -gdwarf-X produces default (DWARFv4) | ||
| CommonCmdArgs.push_back("0x1000000"); |
There was a problem hiding this comment.
Can GetDefaultDwarfVersion be used to set the default dwarf version?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current pull request is merge of #89 #90 and #91 (all approved) on release_90 branch.
It has 3 commits to
Note: this patch would work with Flang patch flang-compiler/flang#863