fix: fix unable to clear created by filter

Fixes #2017
flanksource · Jun 18, 2024 · 1dd909f · 1dd909f
1 parent e8107b8
commit 1dd909f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/components/Configs/Changes/ConfigChangesFilters/ConfigChangesFilters.tsx b/src/components/Configs/Changes/ConfigChangesFilters/ConfigChangesFilters.tsx
@@ -47,7 +47,9 @@ function FilterBadge({ filters, paramKey }: FilterBadgeProps) {
           className="flex flex-row gap-1 px-2 text-xs"
           onRemove={() => onRemove(paramKey, filter)}
         >
-          <span className="text-gray-500 font-semibold">{paramKey}:</span>
+          <span className="text-gray-500 font-semibold">
+            {paramKey === "external_created_by" ? "created_by" : paramKey}:
+          </span>
           <span className="text-gray-500">
             {filter
               .split(":")[0]

diff --git a/src/pages/config/ConfigChangesPage.tsx b/src/pages/config/ConfigChangesPage.tsx
@@ -48,7 +48,7 @@ export function ConfigChangesPage() {
       filter.set("created_by", createdBy);
     }
     if (externalCreatedBy) {
-      filter.set("created_by", externalCreatedBy);
+      filter.set("external_created_by", externalCreatedBy);
     }
     return Object.fromEntries(filter);
   }, [changeSummary, configId, createdBy, externalCreatedBy, source]);