Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1774-Config-changes---filter-by-cell #1931

Merged
merged 2 commits into from
May 22, 2024

Conversation

mainawycliffe
Copy link
Contributor

Fixes #1774

Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
flanksource-ui ✅ Ready (Inspect) Visit Preview May 22, 2024 7:30am

Copy link

netlify bot commented May 16, 2024

Deploy Preview for goofy-euclid-75956c ready!

Name Link
🔨 Latest commit 44441d5
🔍 Latest deploy log https://app.netlify.com/sites/goofy-euclid-75956c/deploys/664d9e53313f9900080946e2
😎 Deploy Preview https://deploy-preview-1931--goofy-euclid-75956c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 16, 2024

Deploy Preview for flanksource-demo-stable ready!

Name Link
🔨 Latest commit 44441d5
🔍 Latest deploy log https://app.netlify.com/sites/flanksource-demo-stable/deploys/664d9e53b39afa00088c9afd
😎 Deploy Preview https://deploy-preview-1931--flanksource-demo-stable.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 16, 2024

Deploy Preview for clerk-saas-ui ready!

Name Link
🔨 Latest commit 44441d5
🔍 Latest deploy log https://app.netlify.com/sites/clerk-saas-ui/deploys/664d9e538c759300082d4299
😎 Deploy Preview https://deploy-preview-1931--clerk-saas-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@moshloop
Copy link
Member

@mainawycliffe

  • Can we use the same colors for the tags in tri-state, also use a gray x instead of a trash button to remove
  • When changing filters, the paging should reset to first page

@mainawycliffe mainawycliffe force-pushed the 1774-Config-changes---filter-by-cell branch from 564de84 to c6d92bf Compare May 21, 2024 06:27
@mainawycliffe mainawycliffe marked this pull request as ready for review May 21, 2024 06:30
refactor: move a few components around

refactor: rename index.ts to badge.ts
@moshloop
Copy link
Member

@mainawycliffe can we url-encode the values - Filter by summary with a , doesn't work

@mainawycliffe mainawycliffe force-pushed the 1774-Config-changes---filter-by-cell branch from 2fa72f1 to 44441d5 Compare May 22, 2024 07:27
@moshloop moshloop merged commit b6e8f8b into main May 22, 2024
14 of 16 checks passed
@moshloop moshloop deleted the 1774-Config-changes---filter-by-cell branch May 22, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config changes - filter by cell
2 participants