2031-In-health-page---on-first-load-we-hide-passing-ones-by-default-However-the-Hide-Passing-toggle-is-switched-off #2040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for flanksource-demo-stable ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for clerk-saas-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for goofy-euclid-75956c ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mainawycliffe
force-pushed
the
2031-In-health-page---on-first-load-we-hide-passing-ones-by-default-However-the-Hide-Passing-toggle-is-switched-off
branch
from
8113c5e
to
b8bc226
Compare
adityathebe
approved these changes
Jun 21, 2024
mainawycliffe
force-pushed
the
2031-In-health-page---on-first-load-we-hide-passing-ones-by-default-However-the-Hide-Passing-toggle-is-switched-off
branch
from
b8bc226
to
3355756
Compare
|
@mainawycliffe this doesn't seem to work - The UI is taking it value from query params and the query is using local storage Can we not just use atomWithStorage, I don't think hidePassing should update the URL state |
|
@moshloop we can, but I thought when sharing a link, you would want to share exactly what you looking at in terms of state? |
mainawycliffe
force-pushed
the
2031-In-health-page---on-first-load-we-hide-passing-ones-by-default-However-the-Hide-Passing-toggle-is-switched-off
branch
from
3355756
to
c687994
Compare
|
@mainawycliffe - This doesn't seem to work - the toggle reflects the local storage state but the view does not |
mainawycliffe
force-pushed
the
2031-In-health-page---on-first-load-we-hide-passing-ones-by-default-However-the-Hide-Passing-toggle-is-switched-off
branch
from
c687994
to
0ef0515
Compare
mainawycliffe
force-pushed
the
2031-In-health-page---on-first-load-we-hide-passing-ones-by-default-However-the-Hide-Passing-toggle-is-switched-off
branch
from
0ef0515
to
59454ff
Compare
moshloop
deleted the
2031-In-health-page---on-first-load-we-hide-passing-ones-by-default-However-the-Hide-Passing-toggle-is-switched-off
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2031