chore: add prometheus connection #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moshloop
reviewed
Jun 16, 2024
| @@ -141,8 +141,8 @@ Metrics | |||
| - name: memory | |||
| lookup: | |||
| prometheus: | |||
| - query: 'sum(container_memory_working_set_bytes{container!=""{{.Values.prometheusLabels}}}) by (pod)' | |||
| url: {{ .Values.prometheusURL | quote }} | |||
| - query: 'sum(container_memory_working_set_bytes{container!=""{{.Values.prometheus.labels | default .Values.prometheusLabels}}}) by (pod)' | |||
There was a problem hiding this comment.
I think these queries also need to move to values - and then we tpl it in here.
moshloop
reviewed
Jun 16, 2024
| @@ -1,3 +1,16 @@ | |||
| --- | |||
| apiVersion: mission-control.flanksource.com/v1 | |||
There was a problem hiding this comment.
I think only create if prometheus url is specified and prometheus.createConnection is true (i.e. we might want to use an existing connection, or share the same connection amongst multiple topologies
moshloop
reviewed
Jun 16, 2024
charts/kubernetes/values.yaml
Outdated
|
|
||
| metrics: | ||
| enabled: true | ||
|
|
||
| # Deprecated: use prometheus.url instead |
There was a problem hiding this comment.
Need to update values.schema.json
yashmehrotra
force-pushed
the
prom-connection
branch
from
fc9c07a
to
6d42116
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: flanksource/mission-control-chart#182
Fixes: #190