Skip to content

Commit

Permalink
documentation: set priorityClassName to system-node-critical
Browse files Browse the repository at this point in the history
flannel pods are not considered critical by the scheduler, which may
cause issues. In case of multiple pods are fighting for resources
there is the possibility of flannel pods be in pending mode indefinitely
  • Loading branch information
frederiko committed Jul 1, 2020
1 parent 8abf12a commit 75fe1e0
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 2 deletions.
1 change: 1 addition & 0 deletions Documentation/kube-flannel-aliyun.yml
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ spec:
app: flannel
spec:
hostNetwork: true
priorityClassName: system-node-critical
nodeSelector:
beta.kubernetes.io/arch: amd64
tolerations:
Expand Down
5 changes: 5 additions & 0 deletions Documentation/kube-flannel.yml
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@ spec:
values:
- amd64
hostNetwork: true
priorityClassName: system-node-critical
tolerations:
- operator: Exists
effect: NoSchedule
Expand Down Expand Up @@ -257,6 +258,7 @@ spec:
values:
- arm64
hostNetwork: true
priorityClassName: system-node-critical
tolerations:
- operator: Exists
effect: NoSchedule
Expand Down Expand Up @@ -351,6 +353,7 @@ spec:
values:
- arm
hostNetwork: true
priorityClassName: system-node-critical
tolerations:
- operator: Exists
effect: NoSchedule
Expand Down Expand Up @@ -445,6 +448,7 @@ spec:
values:
- ppc64le
hostNetwork: true
priorityClassName: system-node-critical
tolerations:
- operator: Exists
effect: NoSchedule
Expand Down Expand Up @@ -539,6 +543,7 @@ spec:
values:
- s390x
hostNetwork: true
priorityClassName: system-node-critical
tolerations:
- operator: Exists
effect: NoSchedule
Expand Down
4 changes: 2 additions & 2 deletions backend/vxlan/device.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ import (
log "github.com/golang/glog"
"github.com/vishvananda/netlink"

"github.com/containernetworking/plugins/pkg/utils/sysctl"
"github.com/coreos/flannel/pkg/ip"
"github.com/containernetworking/plugins/pkg/utils/sysctl"
)

type vxlanDeviceAttrs struct {
Expand Down Expand Up @@ -62,7 +62,7 @@ func newVXLANDevice(devAttrs *vxlanDeviceAttrs) (*vxlanDevice, error) {
return nil, err
}

_, _ = sysctl.Sysctl(fmt.Sprintf("net/ipv6/conf/%s/accept_ra", devAttrs.name), "0")
_, _ = sysctl.Sysctl(fmt.Sprintf("net/ipv6/conf/%s/accept_ra", devAttrs.name), "0")

return &vxlanDevice{
link: link,
Expand Down

0 comments on commit 75fe1e0

Please sign in to comment.