Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't throw an error when using http to connect to etcd #1667

Merged
merged 2 commits into from
Nov 3, 2022
Merged

don't throw an error when using http to connect to etcd #1667

merged 2 commits into from
Nov 3, 2022

Conversation

thomasferrandiz
Copy link
Contributor

Description

  • don't throw an error when using http to connect to etcd, log a warning instead
  • upgrade go/text to fix CVE warning

Todos

  • Tests
  • Documentation
  • Release note

Release Note

None required

@ttys3
Copy link
Contributor

ttys3 commented Nov 2, 2022

this seems almost the same purpose as #1663

@thomasferrandiz
Copy link
Contributor Author

this seems almost the same purpose as #1663

yes, it's the same idea but with a warning about using http instead of https.
If you want, you can add the warning in your PR and I remove it from this one.

@rbrtbnfgl rbrtbnfgl merged commit 8d9e491 into flannel-io:master Nov 3, 2022
@rbrtbnfgl rbrtbnfgl mentioned this pull request Nov 3, 2022
Closed
3 tasks
@thomasferrandiz thomasferrandiz deleted the fix-etcd-https branch March 18, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbrtbnfgl rbrtbnfgl rbrtbnfgl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thomasferrandiz @ttys3 @rbrtbnfgl