main.go: Remove sleep during shutdown #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunjan5
reviewed
Jul 21, 2017
main.go
Outdated
| @@ -44,6 +44,8 @@ import ( | |||
| "github.com/joho/godotenv" | |||
|
|
|||
| // Backends need to be imported for their init() to get executed and them to register | |||
There was a problem hiding this comment.
this comment should be moved to where the imports are
main.go
Outdated
| // Block waiting to renew the lease | ||
| _ = MonitorLease(ctx, sm, bn) | ||
| if !opts.kubeSubnetMgr { | ||
| err = MonitorLease(ctx, sm, bn, wg) |
There was a problem hiding this comment.
shouldn't you be passing &wg to MonitorLease if you're passing the reference?
main.go
Outdated
| @@ -339,10 +360,16 @@ func getConfig(ctx context.Context, sm subnet.Manager) (*subnet.Config, error) { | |||
| } | |||
| } | |||
|
|
|||
| func MonitorLease(ctx context.Context, sm subnet.Manager, bn backend.Network) error { | |||
| func MonitorLease(ctx context.Context, sm subnet.Manager, bn backend.Network, wg sync.WaitGroup) error { | |||
There was a problem hiding this comment.
same here, I think it should be wg *sync.WaitGroup
tomdee
force-pushed
the
remove-shutdown-sleep
branch
from
de8b7a7
to
719cc44
Compare
|
I amended the commits with the markups (since they were small). PTAL @gunjan5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.