backend/vxlan: Add support for "direct routing" #787
Conversation
tomdee
force-pushed
the
vxlan-direct-routing
branch
2 times, most recently
from
74b4346
to
802887f
Compare
This skips vxlan encapsulation if the hosts are on the same subnet
tomdee
force-pushed
the
vxlan-direct-routing
branch
from
802887f
to
bd001e1
Compare
| continue | ||
| } | ||
| if len(routes) == 1 && routes[0].Gw == nil { |
There was a problem hiding this comment.
wonder if you can use any of netlink.Route's attributes to determine if it's a directly connected?
There was a problem hiding this comment.
Isn't that what I'm doing with my .Gw == nil test?
I could also check to see if the FLAG_ONLINK flag is set on the flags attribute if you think that would be better?
There was a problem hiding this comment.
that would be nice but not necessary since your comments are pretty clear
| continue | ||
| } | ||
| if len(routes) == 1 && routes[0].Gw == nil { |
There was a problem hiding this comment.
how would this condition set directRoutingOK to true for subnet.EventRemoved event? maybe I'm missing something, but when we get the EventAdded we program the directRoute which has Gw: attrs.PublicIP.ToIP(), then we get EventRemoved for the same one and if we check this condition where we see if Gw==nil, so the clean up in L173 won't happen?
There was a problem hiding this comment.
The directRoutingOK check is seeing if there's a direct route to the public IP address of other host. If there is, then we add a route to the IP range for that host using the public IP address as the gateway. The "route" to the public IP address for that host is unchanged; it's still directly connected.
So when the remove comes in, the public IP is still directly connected and we can remove the route to the network which uses the public IP as the gateway. Make sense?
There was a problem hiding this comment.
yeah that makes sense, I misunderstood the direct link checking logic and thought directRoutingOk flag will stay false for delete, but it doesn't, so all good now :)
This skips vxlan encapsulation if the hosts are on the same subnet