backend: Get flannel building on windows with stubs #879
Conversation
|
We've added an appveyor build YML to enable CI - however to work you need enable it for the repo in repo settings. Its free for open source projects and is what was just done to get the CNI repo to do CI for windows, see containernetworking/plugins#84 We also preferred adding !windows instead of naming the files _linux.. this leaves them free to compile on *nix and only windows code will be _windows (from subsequent commits) - this feels cleaner... |
|
Looking good, but this will need a few changes before I can merge:
I'll take a look at enabling appveyor on this repo |
jroggeman
force-pushed
the
jroggeman/build_windows
branch
5 times, most recently
from
597d80b
to
77a99f5
Compare
|
@tomdee Made changes, should be good to go |
| @@ -1,3 +1,5 @@ | |||
| // +build !windows | |||
There was a problem hiding this comment.
Can you remove this extra build statement
There was a problem hiding this comment.
removed the above one to remain consistent with style
backend/udp/udp.go
Outdated
| @@ -11,7 +11,7 @@ | |||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |||
| // See the License for the specific language governing permissions and | |||
| // limitations under the License. | |||
| // +build !amd64 | |||
| // +build !amd64,!windows | |||
There was a problem hiding this comment.
Shouldn't the !windows be on a new line?
backend/udp/udp_windows.go
Outdated
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| // +build windows |
There was a problem hiding this comment.
Do the _windows files need a windows build tag?
|
What are the changes to the vendor/* files? |
|
vendor files were whitespace changes from gofmt; I can revert them. |
jroggeman
force-pushed
the
jroggeman/build_windows
branch
from
77a99f5
to
145a4a4
Compare
|
Looks good, merging. |
|
@tomdee Thanks for reviewing and merging. Can enable AppVeyor CI to make sure it keeps building? |
Description
Gets flannel building on windows; the second PR as described in #832.
// +build !windows