Documentation/Manifests: Improve YMLs. #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you make this change to the other two manifest files in this repo too? |
Gacko
changed the title
|
Done. I did not change the legacy init containers in some manifests since it would make them hardly readable. |
Gacko
changed the title
tomdee
reviewed
Nov 24, 2017
| @@ -93,7 +94,7 @@ spec: | |||
| serviceAccountName: flannel | |||
| initContainers: | |||
| - name: install-cni | |||
| image: registry.cn-hangzhou.aliyuncs.com/google-containers/flannel:v0.9.0 | |||
| image: registry.cn-hangzhou.aliyuncs.com/google-containers/flannel:v0.9.1 | |||
There was a problem hiding this comment.
Does this image actually exist? I don't have permissions to push to this repo...
There was a problem hiding this comment.
I don't know. I thought you already did so. I'll revert this change.
|
@Gacko Looks good, but I'm not sure about bumping the aliyun image - it might be safer to just leave that at 0.9.0 |
|
I removed the commit changing the version of the image from the aliyun registry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.