Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace objectName with nameSelector.matchNames #33

Closed
dmgtn opened this issue Aug 14, 2019 · 1 comment · Fixed by #47
Closed

Replace objectName with nameSelector.matchNames #33

dmgtn opened this issue Aug 14, 2019 · 1 comment · Fixed by #47
Assignees
Milestone

Comments

@dmgtn
Copy link
Member

dmgtn commented Aug 14, 2019

Reasons:

  1. We already have matchNames in namespaceSelector
  2. matchNames will allow matching for more than one object at a time

To my eye, objectName looks extremely ugly and non-Kubernetes-API-common, so we better use matchNames from prometheus-operator – at least we will be not the only ones using this keyword. And at least we will use the same approach both for namespace matching and for the object matching.

@dmgtn dmgtn assigned dmgtn and diafour and unassigned dmgtn Aug 14, 2019
@diafour diafour changed the title Replace objectName with selector.matchNames Replace objectName with nameSelector.matchNames Aug 28, 2019
@diafour
Copy link
Contributor

diafour commented Aug 28, 2019

  1. The selector field is nameSelector.matchNames as of Hooks configuration API refactoring #37
  2. Document this feature in HOOKS.md

@dmgtn dmgtn closed this as completed in #47 Sep 3, 2019
@diafour diafour modified the milestones: 1.0.0, 1.0.0-beta.6 Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants