You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have a few problems in API that should be fixed:
First of all – we mistakenly use operation instead of operator in matchExpressions clause. This is a real bug and should be fixed.
We use selector, containing matchLabels and matchExpressions fields. But the more Kubernetes-compatible name will be labelSelector. Rename selector to labelSelector.
* Introduce versioning for hooks configuration API #36
* Hooks configuration API refactoring #37
* Add support for field selector for onKubernetesEvent hooks #35
We have a few problems in API that should be fixed:
operation
instead ofoperator
inmatchExpressions
clause. This is a real bug and should be fixed.selector
, containingmatchLabels
andmatchExpressions
fields. But the more Kubernetes-compatible name will belabelSelector
. Renameselector
tolabelSelector
.matchLabels
andmatchExpressions
tonamespace
. Instead of just adding them tonamespaceSelector
, we better introduce new fieldnamespace
, and then add therelabelSelector
.namespaceSelector
, and instead of itnamespace.labelSelector
(as already suggested above),namespace.nameSelector
(havingmatchNames
).v1
(Introduce versioning for hooks configuration API #36)Full example:
The text was updated successfully, but these errors were encountered: