fix: enable kube events for hooks with namespace.labelSelector bindings #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diafour
changed the title
shvgn
requested changes
Jul 14, 2022
| // Wait until informer for new NS appears. | ||
| g.Eventually(func() bool { | ||
| monImpl := mon.(*monitor) | ||
| return len(monImpl.VaryingInformers) == 3 |
There was a problem hiding this comment.
Counting seems good enough since this behavior looks deterministic. But I suggest to be more strict and test that VaryingInformers actually contains key "test-ns-2"
There was a problem hiding this comment.
I've rewrite this test.
| // Wait until informer appears. | ||
| g.Eventually(func() bool { | ||
| monImpl := mon.(*monitor) | ||
| return len(monImpl.VaryingInformers) == 2 |
There was a problem hiding this comment.
Counting seems good enough since this behavior looks deterministic. But I suggest to be more strict and test that VaryingInformers actually contains expected keys
|
|
||
| // Should update snapshot. | ||
| g.Eventually(func() bool { | ||
| return len(mon.Snapshot()) == 4 |
There was a problem hiding this comment.
I would prefer to find exact object reference in snapshots. We probably don't case about the amount, but we do care about the inclusion of the configmap. What if there is a bug that copies snap[0] all the time orgrows the slice with nils? 
Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
yalosev
approved these changes
Jul 21, 2022
shvgn
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add flag to enable KubeEvents for varying informers after Synchronization phase.
What this PR does / why we need it
See #379 and #399. This fix enables events for hooks with namespace.labelSelector.
Special notes for your reviewer
"before" situation can be emulated by commenting
m.eventsEnabled = truein monitor.go. Test will fail:Does this PR introduce a user-facing change?