1.x pagerduty ack retrieval improvements #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessereynolds
changed the title
|
Looks good to me. |
|
This loads all unacked failing checks for each originally unacked failing check, it's probably the main offender in time usage. It would make sense to see there whether the check that's the subject of the loop is still failing and unacknowledged instead. Increasing the timeout is a good idea as well, but let's do what we can to fix the underlying problem. |
|
Oh yeah, that's awful. Fixing... |
|
|
|
👍 |
jessereynolds
added a commit
that referenced
this pull request
May 13, 2015
…rovements 1.x pagerduty ack retrieval improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This increases the expiry on pagerduty acks running semaphore to 1 hour.
Should address #854 in a fairly terrible kind of way.