Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test workflows PoC #20

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Test workflows PoC #20

merged 1 commit into from
Jun 24, 2021

Conversation

iakovts
Copy link
Contributor

@iakovts iakovts commented Jun 19, 2021

(#19)
With these changes, a github Action will run on any push to the repo, triggering unit tests. This can be modified to run only on selected branches, PRs etc.
I 've also split the dev dependencies into: dev, docs and test to avoid the added overhead of packages not needed for testing (now that i think about it, pip install . && pip install pytest would be good at this stage too).

@flaport
Copy link
Owner

flaport commented Jun 20, 2021

That's awesome!

I'd like to merge as is, but now that you're working on this (and only if it's not too difficult/time consuming).... would it be possible to add an action to release a wheel when I push a tagged commit (and when all test succeed)?

that's something I wanted for a while already, so now that there is someone with github actions knowledge I grab my chance 😅

@iakovts iakovts mentioned this pull request Jun 22, 2021
@flaport
Copy link
Owner

flaport commented Jun 24, 2021

merging this already as discussed in #19 , we can create new PRs for further additions to gitlab-ci.

@flaport flaport merged commit f328b6d into flaport:master Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants