Include Poynting Vector calculation #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to avoid recalculation caching in private attributes is used. It uses `pydantic.PrivateAttr` to conform to pydantic. I am not sure, that this is a beautiful way to do it. It should not be saved when serializing/deserializing.
4 tasks
|
Hi @Jan-David-Black , Cool, I was not aware of In general, so far I am not very happy with Pydantic, it forces you in a mold and anything slightly outside its default usecases (like adding private attributes, in combination with keeping json serializability) turn out to be a complete pain. In for example cell.py I'm using an 'extra' field, which is then excluded from the json schema in the Config class, but I'm not particularly happy with that solution either, but it seems to work for now. In any case... pydantic seems to be the de-facto standard now for dataclasses and I still like it for parsing stuff so I'll probably stick to it. Your PR looks good. Merging :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to avoid recalculation caching in private attributes is used.
It uses
pydantic.PrivateAttrto conform to pydantic. I am not sure, that this is a beautiful way to do it. It should not be saved when serializing/deserializing.Addresses task 1 of #6.
I had to move
jaxlibto conda/mamba install and removeklujaxfrom theenvironment.yml, because it doesn't install properly on macos at the moment. A pull request to fix the problem is open here flaport/klujax#1.