Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid name entry should show some text #217

Closed
lazerwalker opened this issue Jul 3, 2019 · 7 comments
Closed

Invalid name entry should show some text #217

lazerwalker opened this issue Jul 3, 2019 · 7 comments

Comments

@lazerwalker
Copy link
Collaborator

When we reject your name (too short / inappropriate / eventually because it's already taken), we should show a text reason instead of just outlining the box red.

Just the color isn't great for accessibility, plus more possible reasons = more confusing.

@lazerwalker
Copy link
Collaborator Author

This is tricky. PlayFab gives very long description, and doesn't give us a reliable way to distinguish length from already in use from inappropriate.

Might need to do some fuzzy matching on the error message.

@lazerwalker
Copy link
Collaborator Author

A lot of our bad play store reviews are people who claim they can't get past the name screen.

I think this is what's actually happening (probably "name already taken", but could also be profanity or too short). Probably worth figuring out how to provide sensible messages here.

@orta
Copy link
Member

orta commented Jul 7, 2019

I did this last nigh 👍

@lazerwalker
Copy link
Collaborator Author

facepalm

awesome!

@lazerwalker
Copy link
Collaborator Author

I mean, I guess that probably means the problem is something else :/

@orta
Copy link
Member

orta commented Jul 7, 2019

or it was from before late last night?

@lazerwalker
Copy link
Collaborator Author

Ah, hm. There's one from today, but seems totally plausible the actual problem was earlier.

Will hold off investigating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants