Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IR_Template should behave the same as all other emisison models #630

Open
WillJRoper opened this issue May 23, 2024 · 0 comments · May be fixed by #624
Open

IR_Template should behave the same as all other emisison models #630

WillJRoper opened this issue May 23, 2024 · 0 comments · May be fixed by #624
Labels
Dust Issues/PRs related to dust extinction

Comments

@WillJRoper
Copy link
Collaborator

The IR_Template emission model handles the calculation of dust luminosity differently to the other models but doesn't need to. This should be brought in line with the other models where a normalised spectra is returned for scaling.

In another branch, these models have been further modified to bring the dust luminosity calculation "in house" which could also be done once that branch is merged.
@WillJRoper WillJRoper added the Dust Issues/PRs related to dust extinction label May 23, 2024
@WillJRoper WillJRoper linked a pull request Jun 19, 2024 that will close this issue
Draft
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Dust Issues/PRs related to dust extinction
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Using dependency injection for spectra generation flaresimulations/synthesizer
1 participant
@WillJRoper