-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing EmissionModels
and docs rework (Using dependency injection for spectra generation)
#624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillJRoper
changed the title
Using dependency injection for spectra geenration
Using dependency injection for spectra generation
May 20, 2024
Documentation pages that require updating:
|
…ions/synthesizer into emission_templating
…ions/synthesizer into emission_templating
…thesizer into emission_templating
…ions/synthesizer into emission_templating
…ions/synthesizer into emission_templating
7 tasks
WillJRoper
changed the title
Using dependency injection for spectra generation
Introducing Jul 11, 2024
EmissionModels
and docs rework (Using dependency injection for spectra generation)
…ions/synthesizer into emission_templating
…thesizer into emission_templating
…thesizer into emission_templating
christopherlovell
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
EmissionModels
Issues related to EmissionModels
Spectra/SED
Issues relating to spectra and sed objects
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
EmissionModels
which simplify spectra generation by enabling the definition of tree-like templates for atomically defining complex models.EmissionModel
encompasses a single step in spectra generation, e.g. extraction, generation, attenuation, or combination.get_spectra
method which takes anEmissionModel
and parses it generating the necessary spectra (injection).EmissionModels
.EmissionModels
.This PR also includes a complete rewrite of the docs.
This PR closes a myriad of open issues:
get_spectra_*
#627f_esc
parameters for escape from HII regions and unattenuated light #429Issue Type
Checklist