Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening Tag page starts partially scrolled down.. #241

Open
mikejones3 opened this issue Jul 18, 2019 · 5 comments
Open

Opening Tag page starts partially scrolled down.. #241

mikejones3 opened this issue Jul 18, 2019 · 5 comments

Comments

@mikejones3
Copy link

mikejones3 commented Jul 18, 2019

Bug Report

Current Behavior
From the main page of any flarum, if you click a tag on the left-hand side to go to that tag page, it opens the new page partially scrolled down...

Not sure if flarum does this on purpose or if this is a bug. Personally, I do not want it to be partially scrolled down because it either cuts out entirely the tag description or partially. I want users to see this tag description.

Steps to Reproduce

  1. Go to https://discuss.flarum.org/
  2. Click on "support" tag
  3. You will not see the tag description... You have to scroll up. All tags load with you scrolled down a little.

Expected Behavior
The page should not start scrolled down on load.

Screenshots
https://discuss.flarum.org/d/20774-opening-tag-page-starts-partially-scrolled-down

Environment

@tobyzerner
Copy link

tobyzerner commented Aug 18, 2019

This is intended behaviour to prevent the sidebar from being shifted down when you click on an item. https://github.com/flarum/core/blob/689d767f828c80c583135a56c9d334767908d0b5/js/src/forum/components/IndexPage.js#L101-L115

@mikejones3
Copy link
Author

@tobyzerner hmm then what is the point of the hero there at the top if it is not visible or only halfway visible.

I am not sure what you mean by sidebar jump around?

@Ornanovitch
Copy link

Hey and thanks to all of you, flarum dev team :)

I'm currently configuring a forum for my friends, and that behavior surprises me every time. I agree with @mikejones3 on this, it would be more user-friendly to see the tag hero when we enter in an other tag.

@dsevillamartin
Copy link
Member

The problem Toby described was that the sidebar (list of tags, all discussions, subscribed, etc...) would jump and not be at the same position as the page would be scrolled up. So, if you clicked on a tag, your mouse would no longer be over the same button.

Just wanted to clarify this, as it looks like the behavior wasn't clear.

@Ornanovitch
Copy link

Ornanovitch commented Mar 22, 2020

Ok thanks, I understand this point, it wasn't clear for me indeed..!

@askvortsov1 askvortsov1 transferred this issue from flarum/framework Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants