Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing compat exports in core extensions #1933

Closed
6 tasks
clarkwinkelmann opened this issue Nov 14, 2019 · 6 comments
Closed
6 tasks

Missing compat exports in core extensions #1933

clarkwinkelmann opened this issue Nov 14, 2019 · 6 comments
Labels
prio/high type/cleanup

Comments

@clarkwinkelmann
Copy link
Member

clarkwinkelmann commented Nov 14, 2019 •
edited
Loading

This is a list of all the components that are currently not exported from the javascript of our core extensions, making them impossible to extend or reuse.

It's not exhaustive. Feel free to complete it.

Emoji

  • twemoji library
  • simple-emoji-map library
  • components/AutocompleteDropdown

Suspend

  • components/SuspendUserModal.js
  • components/UserSuspendedNotification.js
  • components/UserUnsuspendedNotification.js
@dsevillamartin
Copy link
Member

This will most likely be done with the Mithril v2 rewrite of core extensions (see #1821).

@stale

This comment has been minimized.

Sign in to view
@stale stale bot added the stale Issues that have had over 90 days of inactivity label Feb 12, 2020
@clarkwinkelmann
Copy link
Member Author

Still relevant.

Another extension discussed recently was Mentions. It currently only exports utils/textFormatter, but has so many other components and helper functions that could be re-used or extended.

@stale stale bot removed the stale Issues that have had over 90 days of inactivity label Feb 24, 2020
@franzliedke franzliedke added this to the 0.1 milestone Mar 12, 2020
@clarkwinkelmann
Copy link
Member Author

twemoji and simple-emoji-map should be discussed as part of flarum/issue-archive#161

@davwheat
Copy link
Member

Suspend-related stuff will be fixed with flarum/suspend#34

@askvortsov1
Copy link
Sponsor Member

Since we want to move ahead with #1933, this is now redundant in favor of #1933 and flarum/issue-archive#161

@askvortsov1 askvortsov1 removed this from the 1.0 milestone Apr 16, 2021
This was referenced Mar 10, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
prio/high type/cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@franzliedke @clarkwinkelmann @dsevillamartin @davwheat @askvortsov1