Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call liveHumanTimes() to update ago times every 10s #2208

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Call liveHumanTimes() to update ago times every 10s #2208

merged 1 commit into from
Jun 24, 2020

Conversation

dsevillamartin
Copy link
Member

This file has existed for 5 years, yet it was never used.

Tested, works.

Not sure if we want to call it in Application#mount? I couldn't think of another place.

@dsevillamartin
Call liveHumanTimes() to update ago times every 10s
d31fd83 
This file has existed for 5 years, yet it was never used.
tankerkiller125
tankerkiller125 approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@tankerkiller125 tankerkiller125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for me, seems like a great thing to get working since it's been sitting around so long

@askvortsov1 askvortsov1 merged commit 138c784 into master Jun 24, 2020
@askvortsov1 askvortsov1 deleted the ds/call-live-human-times branch June 24, 2020 00:50
@askvortsov1 askvortsov1 added this to the 0.1.0-beta.14 milestone Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tankerkiller125 tankerkiller125 tankerkiller125 approved these changes

@askvortsov1 askvortsov1 askvortsov1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.0-beta.14
Development

Successfully merging this pull request may close these issues.
3 participants
@dsevillamartin @tankerkiller125 @askvortsov1