-
-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include task scheduling in core #2704
Conversation
When merging, if we decide to keep the helper changes done here, I'll split it into 2 commits:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checks out fine locally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add methods for each way to schedule? There's a LOT of options, so I think what I have here is simpler. On the other hand it's slightly less BC compatible, in case laravel decides to break something on its side. But I still think its way too many methods, and figuring out how to chain them is complicated.
We could make an adapter that reroutes method calls to the actual Event class, that way if laravel breaks something we'll have a BC layer, that said typehinting would be a problem, we could use a phpDoc block for that, but maintaining that can easily become a pain.
I think it's safe to assume that if Laravel breaks this, they've probably broken other things, meaning that we'd only be including that upgrade in a major release. |
f097c5d
to
3addcfb
Compare
3addcfb
to
2536e49
Compare
} | ||
} | ||
|
||
class FakeApp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Multiple class declarations in one file are really not done. It makes discoverability extremely hard. Either:
- move that class into its own file
- or use an anonymous class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I keep forgetting anonymous classes exist. This is the perfect use case for one. I'll open a PR to clean this up, thanks!
Fixes #2281
Changes proposed in this pull request:
Add a
schedule
method to theConsole
extender.Reviewers should focus on:
Confirmed
composer test
).