Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: package manager & installable packages #469

Merged
merged 8 commits into from
Jan 12, 2024
Merged

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Jan 6, 2024

putting here for use in discuss
294670348-6e18c6ed-8abb-4feb-88a9-e8bb060e54ab

@SychO9 SychO9 marked this pull request as ready for review January 6, 2024 17:17
@luceos
Copy link
Member

luceos commented Jan 11, 2024

The docs seem to imply the extension manager is already installed. Nowhere is mentioned how to install this manager in case it isn't installed, eg on existing systems. This might alleviate some support questions.

@GreXXL
Copy link
Member

GreXXL commented Jan 11, 2024

The docs seem to imply the extension manager is already installed. Nowhere is mentioned how to install this manager in case it isn't installed, eg on existing systems. This might alleviate some support questions.

In the downloaded package it's already bundled. I don't know if we also changed the skeleton when you manually install with composer so that it defaults installs as a core extension. In that case it would be fine to describe it "as already installed"?

@SychO9
Copy link
Member Author

SychO9 commented Jan 11, 2024

I don't actually think we should bundle it for those installing from the CLI, but instead include the installation instructions of the extension manager i the section of installing flarum from the CLI, that way it's clear that if you wish to manage extensions from the interface (even though you are currently using the CLI to install) then here it is and how to add it.

Also need to add the extension's installation instructions in the extensions section like daniel mentions.

@SychO9 SychO9 merged commit 07d15e0 into master Jan 12, 2024
1 check passed
@SychO9 SychO9 deleted the sm/installable-packages branch January 12, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants