Skip to content

Commit

Permalink
Allow extra attrs provided to <Select> to be passed through to the …
Browse files Browse the repository at this point in the history
…DOM element (#2959)

* Allow extra attrs provided to `<Select>` to be passed through to the DOM element

* Allow direct passing attrs to the Select wrapper

* Format
  • Loading branch information
davwheat committed Jul 13, 2021
1 parent da20d75 commit 3130e3d
Showing 1 changed file with 18 additions and 2 deletions.
20 changes: 18 additions & 2 deletions js/src/common/components/Select.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import Component from '../Component';
import icon from '../helpers/icon';
import withAttr from '../utils/withAttr';
import classList from '../utils/classList';

/**
* The `Select` component displays a <select> input, surrounded with some extra
Expand All @@ -10,18 +11,33 @@ import withAttr from '../utils/withAttr';
* - `onchange` A callback to run when the selected value is changed.
* - `value` The value of the selected option.
* - `disabled` Disabled state for the input.
* - `wrapperAttrs` A map of attrs to be passed to the DOM element wrapping the `<select>`
*
* Other attributes are passed directly to the `<select>` element rendered to the DOM.
*/
export default class Select extends Component {
view() {
const { options, onchange, value, disabled } = this.attrs;
const {
options,
onchange,
value,
disabled,

// Destructure the `wrapperAttrs` object to extract the `className` for passing to `classList()`
// `= {}` prevents errors when `wrapperAttrs` is undefined
wrapperAttrs: { className: wrapperClassName, ...wrapperAttrs } = {},

...domAttrs
} = this.attrs;

return (
<span className="Select">
<span className={classList('Select', wrapperClassName)} {...wrapperAttrs}>
<select
className="Select-input FormControl"
onchange={onchange ? withAttr('value', onchange.bind(this)) : undefined}
value={value}
disabled={disabled}
{...domAttrs}
>
{Object.keys(options).map((key) => (
<option value={key}>{options[key]}</option>
Expand Down

0 comments on commit 3130e3d

Please sign in to comment.