Skip to content

Commit

Permalink
Remove the "debug" button from request error alerts
Browse files Browse the repository at this point in the history
Using the browser's console to debug failed requests is much more powerful
  • Loading branch information
tobyzerner committed Sep 21, 2018
1 parent 5ce702a commit 64686ef
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 48 deletions.
17 changes: 1 addition & 16 deletions js/src/common/Application.js
@@ -1,9 +1,7 @@
import ItemList from './utils/ItemList';
import Alert from './components/Alert';
import Button from './components/Button';
import ModalManager from './components/ModalManager';
import AlertManager from './components/AlertManager';
import RequestErrorModal from './components/RequestErrorModal';
import Translator from './Translator';
import Store from './Store';
import Session from './Session';
Expand Down Expand Up @@ -333,10 +331,7 @@ export default class Application {

error.alert = new Alert({
type: 'error',
children,
controls: app.forum.attribute('debug') ? [
<Button className="Button Button--link" onclick={this.showDebug.bind(this, error)}>Debug</Button>
] : undefined
children
});

try {
Expand All @@ -351,16 +346,6 @@ export default class Application {
return deferred.promise;
}

/**
* @param {RequestError} error
* @private
*/
showDebug(error) {
this.alerts.dismiss(this.requestErrorAlert);

this.modal.show(new RequestErrorModal({error}));
}

/**
* Construct a URL to the route with the given name.
*
Expand Down
2 changes: 0 additions & 2 deletions js/src/common/compat.js
Expand Up @@ -37,7 +37,6 @@ import Placeholder from './components/Placeholder';
import Separator from './components/Separator';
import Dropdown from './components/Dropdown';
import SplitDropdown from './components/SplitDropdown';
import RequestErrorModal from './components/RequestErrorModal';
import FieldSet from './components/FieldSet';
import Select from './components/Select';
import Navigation from './components/Navigation';
Expand Down Expand Up @@ -101,7 +100,6 @@ export default {
'components/Separator': Separator,
'components/Dropdown': Dropdown,
'components/SplitDropdown': SplitDropdown,
'components/RequestErrorModal': RequestErrorModal,
'components/FieldSet': FieldSet,
'components/Select': Select,
'components/Navigation': Navigation,
Expand Down
30 changes: 0 additions & 30 deletions js/src/common/components/RequestErrorModal.js

This file was deleted.

0 comments on commit 64686ef

Please sign in to comment.