Skip to content

Commit

Permalink
Don't show placeholder when loading discussions
Browse files Browse the repository at this point in the history
  • Loading branch information
tobyzerner committed Sep 4, 2015
1 parent ece23de commit 695df18
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion js/forum/src/components/DiscussionList.js
Expand Up @@ -54,7 +54,7 @@ export default class DiscussionList extends Component {
});
}

if (this.discussions.length == 0) {
if (this.discussions.length === 0 && !this.loading) {
const text = 'Looks like there are no discussions here. Why don\'t you create a new one?';
return (
<div className="DiscussionList">
Expand Down

2 comments on commit 695df18

@InfoLibre
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you replace "Looks like there are no discussions here. Why don't you create a new one?" with a variable in order to have it translatable ?
This is also in flarum/vendor/flarum/core/js/forum/dist/app.js

@franzliedke
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part of #118.

Please sign in to comment.