Database changes #1344
Database changes #1344
Conversation
|
Please request reviews when this is out of WIP. :) |
|
Absolutely. Feel free to discuss anything that comes up in the meantime, might save some time refactoring it all over again 👍 |
| @@ -18,7 +18,6 @@ | |||
| $table->integer('post_id')->unsigned(); | |||
| $table->integer('user_id')->unsigned(); | |||
|
|
|||
| $table->foreign('post_id')->references('id')->on('posts')->onDelete('cascade'); | |||
There was a problem hiding this comment.
I think this migration is already newer than yours:
migrations/2018_01_11_120604_change_posts_table_to_innodb.php
I'll put it back.
|
Whew, quite big. If we get #1346 merged first, this one will be easier to review, right? (Still, this might need to be split up, to be honest.) |
luceos
force-pushed
the
1236-database-changes
branch
from
8b8d5bd
to
665ac17
Compare
|
@flarum/core just to prevent confusion. I force pushed a clean version of the branch here, I'm basing it off of master. WIP. |
|
Seems like most of the changes in core are done. Part of the referenced issue is done. Now need to take care of the extensions. |
|
Waiting on #1418 |
|
Update: have added model/JSON-API attribute renaming to this PR as it is completed project-wide. Awaiting feedback from @franzliedke on #1344 (comment) and @luceos testing table prefixes. In the meantime I will work on an indices PR. |
|
I have added a separate ticket for the table prefix thing, no need for that to block this PR. |
|
Sorry guys, I currently have little time available. Noticed I was expected to run some tests with table prefixes. |
|
Table prefixes now have a separate PR. This only needs resolving the migration thing now. 🙌 |
|
Which I will do by the end of the week :D |
|
@franzliedke Please merge this (and the related PRs) if you are happy. |
|
@tobscure Should we remove the |
|
@franzliedke No, because extensions can still safely use it – remember, their migrations need to be able to run on the most up-to-date Flarum database, so the |
|
😄 this got merged.. .. .. .. .. omg |
Closes #1236
Related PRs
flarum/akismet#10
flarum/approval#15
flarum/flags#15
flarum/likes#16
flarum/lock#16
flarum/mentions#34
flarum/sticky#11
flarum/subscriptions#18
flarum/suspend#19
flarum/tags#53