View Extender (add namespace) #2134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… namespaces used in flarum (those are added after extenders are loaded), so I'd like to hold off on that until later.
|
What do you think about naming the class Hmm... 🤔 ... do we really need other operations? We barely use the concept of namespaces in core, so there's nothing there to replace. And I don't want to suggest removing / replacing other extensions' namespaces is a good thing (or important enough to deal with in one of the bundled extenders). |
franzliedke
suggested changes
Jul 10, 2020
franzliedke
suggested changes
Jul 17, 2020
franzliedke
approved these changes
Jul 17, 2020
|
I took care of the lazy extending (requested in #2134 (comment)) and the renaming (discussed in #2134 (comment)) in master. Thanks for the PR! 🙌 |
franzliedke
added a commit
to flarum/mentions
that referenced
this pull request
Jul 17, 2020
franzliedke
added a commit
to flarum/subscriptions
that referenced
this pull request
Jul 17, 2020
franzliedke
added a commit
to flarum/tags
that referenced
this pull request
Jul 17, 2020
askvortsov1
pushed a commit
to flarum/mentions
that referenced
this pull request
Mar 11, 2022
askvortsov1
pushed a commit
to flarum/subscriptions
that referenced
this pull request
Mar 11, 2022
askvortsov1
pushed a commit
to flarum/tags
that referenced
this pull request
Mar 11, 2022
askvortsov1
pushed a commit
to flarum/mentions
that referenced
this pull request
May 10, 2022
askvortsov1
pushed a commit
to flarum/subscriptions
that referenced
this pull request
May 10, 2022
askvortsov1
pushed a commit
to flarum/tags
that referenced
this pull request
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of #1891
Changes proposed in this pull request:
Add view extender with addNamespace method. I called it this instead of just ->namespace() in case we want to support prependNamespace, replaceNamespace, etc
Reviewers should focus on:
Do we want to include replaceNamespace here? I think that might be useful. EDIT: Not yet. Flarum's namespaces are loaded after extenders do their thing, so it wouldn't work there, hence, we should hold off on that for now.
Confirmed
composer test).