Introduce RequestUtil #2449
Merged
Introduce RequestUtil #2449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askvortsov1
requested review from
clarkwinkelmann,
dsevillamartin,
luceos,
SychO9 and
tankerkiller125
SychO9
reviewed
Nov 11, 2020
|
Yeah, also I haven't changed any of the usages in the code yet. Actually I should have put this in the issue as a comment (since I just want to confirm which attributes we want to provide an API for) not as a PR, not sure what I was thinking |
Abstracts access to following request attributes: - actor - session - locale - route name
askvortsov1
force-pushed
the
as/request-util
branch
from
01b35ae
to
2584be8
Compare
askvortsov1
requested review from
SychO9,
luceos and
KyrneDev
and removed request for
luceos,
tankerkiller125,
clarkwinkelmann,
dsevillamartin and
SychO9
franzliedke
reviewed
Apr 4, 2021
|
|
||
| class RequestUtil | ||
| { | ||
| public static function getActor(Request $request): User |
There was a problem hiding this comment.
I have a branch lying around somewhere that basically does the same thing, but more along the lines of Actor::fromRequest(). I liked that a lot. Maybe you like the idea, too? 😄
There was a problem hiding this comment.
Just saw more discussion in #2703 and related tickets. Have fun. 😀
There was a problem hiding this comment.
Actor is sensible too, but I prefer RequestUtil because:
- While getting it is clean, setting it results in clunky naming, as with the user method.
- If we need to encapsulate more stuff, we don't need to add more util classes / force people to import as much stuff. Perhaps separate classes is slightly better with respect to single responsibility, but I think encapsulating request data is still fairly granular. Better than adding it onto
Useranyhow 🙈
SychO9
approved these changes
Apr 7, 2021
tankerkiller125
approved these changes
Apr 7, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #869
Abstracts access to following request attributes:
Are there any attributes on here that we're missing (or that we should exclude)? $actor is the biggest one that needs to be abstracted away IMO, do we even need the others?