Search Extender and tests #2483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askvortsov1
requested review from
franzliedke,
luceos,
clarkwinkelmann,
SychO9 and
tankerkiller125
askvortsov1
changed the base branch from
master
to
as/use-filterer-for-ListPostController
askvortsov1
force-pushed
the
as/use-filterer-for-ListPostController
branch
from
5d5b139
to
fb1831e
Compare
askvortsov1
force-pushed
the
as/simple-flarum-search
branch
2 times, most recently
from
9dc049a
to
a8fbc4e
Compare
SychO9
reviewed
Jan 27, 2021
askvortsov1
force-pushed
the
as/simple-flarum-search
branch
from
312d180
to
3ce0cff
Compare
SychO9
requested changes
Jan 28, 2021
tankerkiller125
approved these changes
Feb 4, 2021
|
Awesome, thanks guys! We'll merge this after the 2 dependency search refactor PRs |
|
Actually looks like this doesn't depend on the search/filter split (or at least I don't believe so), so I'll try merging it tomorrow. That should make review for the search/filter split PR a bit easier since we'll have the search architecture right there to compare. |
askvortsov1
force-pushed
the
as/simple-flarum-search
branch
from
3fcfc3e
to
fe2c6fe
Compare
askvortsov1
changed the base branch from
as/use-filterer-for-ListPostController
to
master
[ci skip] [skip ci]
[ci skip] [skip ci]
[ci skip] [skip ci]
[ci skip] [skip ci]
askvortsov1
force-pushed
the
as/simple-flarum-search
branch
from
fe2c6fe
to
eaabd6e
Compare
KyrneDev
pushed a commit
that referenced
this pull request
Feb 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1891
Part of flarum/issue-archive#286
Part 3 of #2454
Changes proposed in this pull request:
SimpleFlarumSearchextender has been addedSearchingand gambits have been deprecatedConfirmed
composer test).