Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Extension Categories #2604

Merged
merged 2 commits into from Mar 1, 2021
Merged

Simplify Extension Categories #2604

merged 2 commits into from Mar 1, 2021

Conversation

KyrneDev
Copy link
Contributor

@KyrneDev KyrneDev commented Feb 16, 2021

Changes proposed in this pull request:
Extension categories can be hard to pick for developers. This makes it really simple, features, languages, and themes. Nice and easy to pick from. It makes the admin panel look quite a bit better too, fewer dividers.

  • Frontend changes: tested on a local Flarum installation.

Required changes:

@KyrneDev KyrneDev changed the title Simplify Simplify Extension Categories Feb 16, 2021
Copy link
Sponsor Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I feel like authentication and moderation might be separate enough to warrant their own categories, but don't feel strongly about it whatsoever.

Since the vast majority of extensions will be feature-based, perhaps our convention should be omitting a category for those?

@askvortsov1
Copy link
Sponsor Member

Testing this out again, it's instantly a LOT nicer. I hadn't realized how much time I spent looking between categories.

@askvortsov1 askvortsov1 merged commit b7379bf into master Mar 1, 2021
@askvortsov1 askvortsov1 deleted the ck/adminux-category branch March 1, 2021 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants