Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow extra attrs provided to <Select> to be passed through to the DOM element #2959

Merged
merged 3 commits into from
Jul 13, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 18 additions & 2 deletions js/src/common/components/Select.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import Component from '../Component';
import icon from '../helpers/icon';
import withAttr from '../utils/withAttr';
import classList from '../utils/classList';

/**
* The `Select` component displays a <select> input, surrounded with some extra
Expand All @@ -10,18 +11,33 @@ import withAttr from '../utils/withAttr';
* - `onchange` A callback to run when the selected value is changed.
* - `value` The value of the selected option.
* - `disabled` Disabled state for the input.
* - `wrapperAttrs` A map of attrs to be passed to the DOM element wrapping the `<select>`
*
* Other attributes are passed directly to the `<select>` element rendered to the DOM.
*/
export default class Select extends Component {
view() {
const { options, onchange, value, disabled } = this.attrs;
const {
options,
onchange,
value,
disabled,

// Destructure the `wrapperAttrs` object to extract the `className` for passing to `classList()`
// `= {}` prevents errors when `wrapperAttrs` is undefined
wrapperAttrs: { className: wrapperClassName, ...wrapperAttrs } = {},

...domAttrs
} = this.attrs;

return (
<span className="Select">
<span className={classList('Select', wrapperClassName)} {...wrapperAttrs}>
<select
className="Select-input FormControl"
onchange={onchange ? withAttr('value', onchange.bind(this)) : undefined}
value={value}
disabled={disabled}
{...domAttrs}
>
{Object.keys(options).map((key) => (
<option value={key}>{options[key]}</option>
Expand Down