Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mail settings select component never being used #3120

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

clarkwinkelmann
Copy link
Member

@clarkwinkelmann clarkwinkelmann commented Oct 23, 2021

Changes proposed in this pull request:
Fixes a regression introduced in beta 16 with #2593 where the select-style mail settings stopped being rendered as selects. This affects the Mailgun region select which becomes a text input without any help as to what should be entered.

Screenshot
Beta 15:
image

Flarum 1.1:
image

After fix:
image

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Copy link
Sponsor Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM. Thanks!

@askvortsov1 askvortsov1 merged commit 9416b1c into flarum:master Oct 25, 2021
@SychO9 SychO9 added this to the 1.2 milestone Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants