Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix broken contribution link in README; add screenshot #3211

Merged
merged 4 commits into from Dec 20, 2021
Merged

docs: fix broken contribution link in README; add screenshot #3211

merged 4 commits into from Dec 20, 2021

Conversation

komandar
Copy link
Contributor

Fix broken contribution link at core readme.md. Also migrate the readme.md info from flarum readme to the core one.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

davwheat
davwheat requested changes Dec 16, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@komandar @davwheat
Apply suggestions from code review
461fff2 
Add suggestions from davwheat

Co-authored-by: David Wheatley <hi@davwheat.dev>
davwheat
davwheat reviewed Dec 17, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
@komandar @davwheat
Update README.md
fc6e86e 
Apply suggestions from code review

Co-authored-by: David Wheatley <hi@davwheat.dev>
@davwheat davwheat changed the title Kom/update-readme-file Fix broken contribution link at readme file docs: fix broken contribution link at readme file; add screenshot Dec 20, 2021
@davwheat davwheat changed the title docs: fix broken contribution link at readme file; add screenshot docs: fix broken contribution link in README; add screenshot Dec 20, 2021
@askvortsov1 askvortsov1 merged commit edde6be into flarum:master Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davwheat davwheat davwheat approved these changes

@askvortsov1 askvortsov1 askvortsov1 approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@komandar @davwheat @askvortsov1