Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Composer discussion title not visible with certain colors #3413

Merged
merged 1 commit into from May 9, 2022

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented May 6, 2022

Fixes #0000

Changes proposed in this pull request:
When a secondary color of #efefef for example is used, the composer discussion title is not visible when focused out. the control color value should be used instead.

Screenshot

Before After
Screenshot from 2022-05-06 13-28-55 Screenshot from 2022-05-06 13-29-15

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@SychO9 SychO9 added the type/bug label May 6, 2022
@luceos luceos merged commit 903026a into main May 9, 2022
@luceos luceos deleted the sm/composer-discussion-title-visibility branch May 9, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants