Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added title: gambit for discussions #888

Closed
wants to merge 1 commit into from
Closed

Added title: gambit for discussions #888

wants to merge 1 commit into from

Conversation

kevindierkx
Copy link

This adds support for a title: gambit for discussions.

If something is missing or incorrect let me know. ;)

@tobyzerner
Copy link
Contributor

Thanks for the PR! 😄

Unfortunately I don't think we'll merge this one for two reasons:

  1. Using LIKE in this case is not going to perform acceptably in large forums
  2. We ultimately want to integrate title searching into the default keyword search, rather than as a gambit – see Search discussion titles too #257, and feel free to post there if you have any ideas!

Also, a heads up for future contributions: the copyright in the header comment block refers to the whole project rather than the individual file, so it shouldn't be changed.

@tobyzerner tobyzerner closed this Mar 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants