Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move locale files from language pack to extensions #175

Merged
merged 2 commits into from Feb 17, 2021
Merged

Move locale files from language pack to extensions #175

merged 2 commits into from Feb 17, 2021

Conversation

rob006
Copy link
Contributor

@rob006 rob006 commented Oct 24, 2020

@askvortsov1
Copy link
Sponsor Member

@rob006 we've discussed this internally and are ready to proceed, sorry for the delay in acting on this. Could you update the core and tags PRs to reflect changes made since this was opened?

@rob006
Copy link
Contributor Author

rob006 commented Feb 17, 2021

I'll try to do it this evening or tomorrow. There is also a new extension to move (nicknames).

@askvortsov1
Copy link
Sponsor Member

Thank you so much for bearing with us on this!

@rob006
Copy link
Contributor Author

rob006 commented Feb 17, 2021

@askvortsov1 Done.

@askvortsov1 askvortsov1 merged commit 1edf9e4 into flarum:master Feb 17, 2021
@rob006 rob006 deleted the move-locale-files-to-extensions branch February 17, 2021 21:30
@rob006
Copy link
Contributor Author

rob006 commented Feb 17, 2021

@askvortsov1 I think you missed flarum/nicknames#3

@askvortsov1
Copy link
Sponsor Member

I did, thanks for finding that :D

rob006 added a commit to rob006-software/flarum-translations that referenced this pull request Feb 17, 2021
rob006 added a commit to rob006-software/flarum-translations-builder that referenced this pull request Feb 17, 2021
… files were moved from language pack to extensions and for now there is no stable release with locale file in extension repository.

refs flarum/lang-english#175
@qiaeru
Copy link
Contributor

qiaeru commented Feb 18, 2021

How this affects other language packs?

By the way, with this change, translators cannot follow changes/commits easily. 😟

@askvortsov1
Copy link
Sponsor Member

How this affects other language packs?

By the way, with this change, translators cannot follow changes/commits easily.

Important question, but could you put it in flarum/framework#2090, which is the global issue for discussion?

@rob006
Copy link
Contributor Author

rob006 commented Feb 18, 2021

@qiaeru AFAIK it does not affect other language packs at all. While it indeed may make it harder to sync changes, core extensions are only part of the ecosystem and most of installations will use also other community extensions, so to make useful language pack you need to cover also other translations that were never available in this repository. I highly recommend to take a look at https://discuss.flarum.org/d/20807-simplify-translation-process-with-weblate. You can also track all changes in https://github.com/rob006-software/flarum-translations/commits/master/sources - there should all changes in translations of any popular extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants