Notify about a new Discussion

[terabin]

When a new discussion start, pusher don't do anything, a discussion started is a new post too, so, makes sense?

[tobyzerner]

The PostWasPosted event is actually fired upon new discussion creation as well. You can see this happening in:

1. StartDiscussionHandler, which dispatches the PostReply command
2. PostReplyHandler, which creates a new post with CommentPost::reply
3. CommentPost::reply which raises the PostWasPosted event.

However I suspect it's not resulting in a Pusher message because the discussion's startPost is only updated after the PostWasPosted event is fired, and thus the $event->post->isVisibleTo(new Guest) condition is failing. (Haven't confirmed this though.)

Not sure if it's worth doing some refactoring in core so that the discussion's startPost is updated before the PostWasPosted event is fired, or just to use your solution. I will keep thinking about it.

Thanks for the PR, btw!

[askvortsov1]

I am not opposed to handling these 2 separately. Passing the Posted event up through to CreateDiscussionController would be a pain. However, this needs to be updated to reflect changes to Flarum over the past few years.

[askvortsov1]

Closing as outdated. I'm also not sure that this is a problem any more. @terabin feel free to reopen if this is still a problem, and you're still interested in taking it on.