Add suspended gambit #23
Conversation
askvortsov1
requested review from
tankerkiller125,
clarkwinkelmann and
dsevillamartin
|
What would the use case for this gambit be? |
|
In the user directory extension, we discussed adding a filter to see who is / isn't suspended. It was proposed that this gambit be added here instead of in user directory so that it could be available more universally |
|
Wouldn't this allow anyone to see who is suspended? Not everyone has permission to see that... |
There was a problem hiding this comment.
I would suggest wrapping the two wheres in a group to prevent any issue with other gambits:
->where(function(Builder $builder) {
$builder->where()->orWhere();
})
Also as @datitisev points out it needs a permission check.
I think we can re-use "who can suspend" that's already used to decide who can see the suspend badge https://github.com/flarum/suspend/blob/master/src/Listener/AddUserSuspendAttributes.php#L32
askvortsov1
force-pushed
the
as/add_suspended_gambit
branch
from
89a3d23
to
24ff144
Compare
askvortsov1
requested review from
dsevillamartin and
tankerkiller125
and removed request for
tankerkiller125 and
dsevillamartin
| protected function conditions(AbstractSearch $search, array $matches, $negate) | ||
| { | ||
| if (! $search instanceof UserSearch) { | ||
| throw new LogicException('This gambit can only be applied on a DiscussionSearch'); |
There was a problem hiding this comment.
I think you meant to write UserSearch here
There was a problem hiding this comment.
Ah that's awkward 🙈, I'll push a fix shortly. Thanks for catching this!
* Add is:suspended gambit * Wrap where clauses in function * Added permission check for suspended gambit * Apply fixes from StyleCI Co-authored-by: luceos <daniel+github@klabbers.email>
* Add is:suspended gambit * Wrap where clauses in function * Added permission check for suspended gambit * Apply fixes from StyleCI Co-authored-by: luceos <daniel+github@klabbers.email>
Add gambit for filtering suspended / not suspended users