New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display suspension to user #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this, will be very useful! In addition to the above comments, I think the translations/wording could be a bit clearer as to the difference between "reason" and "message"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had the opportunity to try it out locally, a few thoughts:
- Indefinite suspensions aren't shown as such to the user, neither in the alert modal or the notification. It just says "16 years".
- Is the suspend reason supposed to be accessible to admins anywhere?
Also, would the associated migrations pose issues for existing communities with tens of millions of users? |
My understanding after looking at this exact issue for a previous employer is that when adding a new column to existing tables, defaulting to |
@imorland https://i.imgur.com/D4RQfS1.png possibly a timezone issue? |
Yes, very much so.. |
This should now be resolved 🤞 |
@SychO9 sorry about that, I think I've got it as you requested now 🤞 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Epic! thank you very much!
Addresses flarum/framework#1447
Recreation of #34, before that got polluted
SuspendUserModal
to include two new optional fields: reason (for moderator use) and message (for display to the suspended userForm-group
components to anItemList
for extensibilitycompat
exports