Fix marshmallow OpenAPI 3.x.x support. #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbenua
force-pushed
the
marshmallow-oas3-support
branch
from
bfa6670
to
d51dda8
Compare
Add version check, improve `$ref` paths.
jbenua
force-pushed
the
marshmallow-oas3-support
branch
3 times, most recently
from
7a2c979
to
d8f3f5f
Compare
jbenua
force-pushed
the
marshmallow-oas3-support
branch
from
d8f3f5f
to
5add92c
Compare
jbenua
force-pushed
the
marshmallow-oas3-support
branch
from
494cedf
to
3fd31ea
Compare
|
Thank you. I will test it in a separate branch first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some hardcoded variables in
flasgger/marshmallow_apispec.pyso it won't work with openapi 3.x.x standart correctly even if version was specified forSwaggerobject and just generated wrong$refs(e.g.#/definitions/...instead of#/components/schemas/..., though the schemas themselves were placed correctly incomponents/schemas).